Issue #11004: enable additional docstring snippets in CI validation#11464
Open
TanKaizokuO wants to merge 3 commits into
Open
Issue #11004: enable additional docstring snippets in CI validation#11464TanKaizokuO wants to merge 3 commits into
TanKaizokuO wants to merge 3 commits into
Conversation
|
@TanKaizokuO is attempting to deploy a commit to the deepset Team on Vercel. A member of the Team first needs to authorize it. |
anakin87
requested changes
Jun 1, 2026
Member
anakin87
left a comment
There was a problem hiding this comment.
Please sign the CLA, then I'll review the PR
Member
|
See #11468 (review) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Enabled 8 additional docstring code snippets to run in CI by removing
<!-- test-ignore -->markers and making examples CI-friendly.Key updates:
ByteStream.NamedEntityExtractor.OpenAPIClient.from_specto avoid external requests.How did you test it?
Regenerated docs and validated snippets:
hatch run docs hatch -e test run python docs-website/scripts/test_python_snippets.py --verbose \ tmp_api_reference/converters_api.md \ tmp_api_reference/embedders_api.md \ tmp_api_reference/extractors_api.md \ tmp_api_reference/connectors_api.mdAdditional passing snippets:
Total: +8 passing snippets
Also verified:
Notes for the reviewer
<!-- test-ignore -->markers were validated successfully.Checklist