-
Notifications
You must be signed in to change notification settings - Fork 8
fix: Fix deepnote notebook deserializer and file change watcher #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
6802960
2de7885
bc2de06
3a418c1
9b5c107
77c0347
6dc77a0
8898be9
c74ffa7
8d061ac
5388ead
6d05f22
c5342a3
3e7dfc9
c160ae3
0b2504a
9d5c6c0
44bd482
36cc1e6
71579cf
23fdcca
824f471
c6d21e6
5d9d6e2
4962616
552366b
bd4d5fd
cb4644f
ec96f53
d44c1aa
7815f42
855f38c
f72b0fa
8e6f679
0396a2c
06d3197
f4b79d3
c83af55
40f6c67
46cbcda
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import { inject, injectable, optional } from 'inversify'; | ||
| import { commands, l10n, workspace, window, type Disposable, type NotebookDocumentContentOptions } from 'vscode'; | ||
| import { commands, l10n, window, workspace, type Disposable, type NotebookDocumentContentOptions } from 'vscode'; | ||
|
|
||
| import { IExtensionSyncActivationService } from '../../platform/activation/types'; | ||
| import { IExtensionContext } from '../../platform/common/types'; | ||
|
|
@@ -51,6 +51,11 @@ export class DeepnoteActivationService implements IExtensionSyncActivationServic | |
|
|
||
| this.registerSerializer(); | ||
| this.extensionContext.subscriptions.push(this.editProtection); | ||
| this.extensionContext.subscriptions.push( | ||
| workspace.onDidOpenNotebookDocument((doc) => { | ||
| void this.serializer.verifyDeserializedNotebook(doc); | ||
| }) | ||
| ); | ||
|
Comment on lines
+54
to
+58
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Fire-and-forget async calls may overlap. Rapid notebook opens trigger concurrent 🤖 Prompt for AI Agents |
||
| this.extensionContext.subscriptions.push( | ||
| workspace.onDidChangeConfiguration((event) => { | ||
| if (event.affectsConfiguration('deepnote.snapshots.enabled')) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 87
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 1794
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 6998
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 123
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 1409
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 2412
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 3805
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 50
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 2138
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 1183
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 335
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 2223
🏁 Script executed:
Repository: deepnote/vscode-deepnote
Length of output: 601
Add
commandPalettescoping to gate this command to Deepnote notebooks.The command is globally discoverable in the palette but the handler silently returns when no active Deepnote notebook exists, creating a dead command outside that context. Add
"when": "notebookType == 'deepnote'"to the command definition, following the pattern used elsewhere in the manifest.🤖 Prompt for AI Agents