fix(train): dispatch registered learning rate schedules#5776
Conversation
Use the shared BaseLR registry in JAX, TF2, and pt_expt so cosine and WSD schedules are honored consistently with the input schema. Coding-Agent: Codex Codex-Version: codex-cli 0.144.1 Model: gpt-5.6-sol Reasoning-Effort: xhigh
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughA shared ChangesLearning-rate schedule construction
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Trainer
participant make_learning_rate_schedule
participant BaseLR
Trainer->>make_learning_rate_schedule: pass learning-rate parameters and num_steps
make_learning_rate_schedule->>BaseLR: construct registered schedule
BaseLR-->>Trainer: return selected schedule
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5776 +/- ##
==========================================
- Coverage 79.69% 79.57% -0.12%
==========================================
Files 1020 1020
Lines 116359 116356 -3
Branches 4303 4306 +3
==========================================
- Hits 92736 92594 -142
- Misses 22076 22219 +143
+ Partials 1547 1543 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
BaseLRregistrypt_expttraining soexp,cosine, andwsdfollow the common schemaAddresses the learning-rate checklist items in #5755, #5756, and #5757. The remaining checklist items in those issues are intentionally left open.
Tests
venv/bin/pytest source/tests/universal/dpmodel/utils/test_learning_rate.py -qvenv/bin/pytest source/tests/pt_expt/test_training.py::TestTraining::test_training_loop -qDP_TEST_TF2_ONLY=1 venv/bin/pytest source/tests/tf2/test_training.py -qvenv/bin/ruff check .venv/bin/ruff format .JAX integration tests were not run locally because the existing virtual environment does not include JAX/Optax; the shared dispatch regression test covers the schedule factory used by the JAX trainer.
Coding agent: Codex
Codex version: codex-cli 0.144.1
Model: gpt-5.6-sol
Reasoning effort: xhigh
Summary by CodeRabbit
New Features
Bug Fixes
Tests