Fix: Support out_current=2 with multiple MPI processes#7624
Open
AsTonyshment wants to merge 1 commit into
Open
Fix: Support out_current=2 with multiple MPI processes#7624AsTonyshment wants to merge 1 commit into
out_current=2 with multiple MPI processes#7624AsTonyshment wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
No linked issue. The bug was reproduced locally.
What's changed?
out_current = 2was introduced in PR #6886 as a matrix-commutation method for calculating current. Its multi-process path was already known to crash when it was introduced, and this bug has remained unresolved since then.out_current = 2incorrectly used global orbital and band indices to access MPI-local distributed matrices, causing heap corruption with multiple MPI ranks. It also did not reduce rank-local current contributions.This PR:
out_current = 2now works with multiple MPI ranks and remains numerically consistent with the single-rank result. The related parameter and developer documentation was also clarified.Unit Tests and/or Case Tests for my changes
Case test: the same LCAO RT-TDDFT calculation (bulk Si with 2×2×2 k-point sampling) was run with one MPI rank and 32 OpenMP threads, and with four MPI ranks and 8 OpenMP threads per rank. The currents in
current_tot_comm.txtoverlap throughout all 10 time steps.Governance Notes
source_ioRT-TDDFT current-output path; no core interfaces or workflows are changed.