#963 Update Gradle build mechanism to support Kotlin DSL with Gradle v6.3#974
Open
loxal wants to merge 2 commits intodeeplearning4j:masterfrom
Open
#963 Update Gradle build mechanism to support Kotlin DSL with Gradle v6.3#974loxal wants to merge 2 commits intodeeplearning4j:masterfrom
loxal wants to merge 2 commits intodeeplearning4j:masterfrom
Conversation
Contributor
loxal
commented
Apr 20, 2020
loxal
commented
- provide specific & tested Gradle version to guarantee a working example
- convert dynamically-typed Gradle script to statically-typed Kotlin DSL
- update dependencies
- cleanup imports
…L with the latest Gradle v6.3 * provide specific & tested Gradle version to guarantee a working example * convert dynamically-typed Gradle script to statically-typed Kotlin DSL * update dependencies * cleanup imports Signed-off-by: Alex <alexander.orlov@loxal.net>
RobAltena
approved these changes
Apr 22, 2020
Contributor
RobAltena
left a comment
RobAltena
left a comment
There was a problem hiding this comment.
Looks good. Thank you!
Contributor
Author
|
@treo are you going to merge this PR to master at some point? |
Member
|
There is a bigger example repository restructuring coming in a few days, in order to not loose this PR in the aftermath, I'm keeping it open to add it in afterwards and to make sure that the attribution doesn't get lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.