fix: DH-22976 ui.table filters to update when changed programmatically#1377
fix: DH-22976 ui.table filters to update when changed programmatically#1377SimonVutov wants to merge 5 commits into
Conversation
|
ui docs preview (Available for 14 days) |
SimonVutov
force-pushed
the
feat-DH-21841-fix-user-to-modify
branch
from
2e9c1ae to
8961441
Compare
|
ui docs preview (Available for 14 days) |
SimonVutov
force-pushed
the
feat-DH-21841-fix-user-to-modify
branch
from
8961441 to
8eba401
Compare
|
ui docs preview (Available for 14 days) |
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
This does allow the user to change the sorts, which is great. However, those changed sorts do not persist as they should (as described in my comment on #1358 (comment)).
I think to fix this properly (for both this case and the filters case described in DH-22976 that I've also assigned to you), we'll need changes in IrisGrid to handle this correctly. I think. I have a snippet specifically for sorting on #1358 (review)
|
ui docs preview (Available for 14 days) |
SimonVutov
changed the title
|
ui docs preview (Available for 14 days) |
1 similar comment
|
ui docs preview (Available for 14 days) |
There was a problem hiding this comment.
Add e2e test for this guy to make sure of the following:
- Filters/sorts update correctly when changed programmatically
- User can still change the filters and sorts, and those changes persist after refreshing
See an example e2e test with persistence https://github.com/deephaven/deephaven-plugins/pull/1379/changes#diff-297dc965f80789b8ed682341089a82d6f946c164dcab51bb3b08b34dff151a02
|
ui docs preview (Available for 14 days) |
2 participants
sorts / quick_filters are server-owned: the server controls the value, so updating the prop re-applies it and replaces whatever the user changed in the UI.
New default_sorts / default_quick_filters are user-owned: they set the initial value, then the user owns it from there — their changes are persisted and restored on reload. Use one or the other for a given facet, not both.