feat: DH-21375: Integrate databars with UI table format #1289
+569
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@copilot Can you check how this PR compares to the plan at https://github.com/deephaven/deephaven-plugins/pull/1282/changes#diff-4b3243a5e436df978a8e62a555524a2fd6f899e8f65248f3879f74611bc0947d and comment if you think there are any discrepancies between the plan the this implementation? Do not open a new pull request, just let me know if there are any discrepancies |
Contributor
|
@mattrunyon I've opened a new pull request, #1290, to work on those changes. Once the pull request is ready, I'll request review from you. |
gzh2003
requested review from
mattrunyon
and removed request for
margaretkennedy
gzh2003
force-pushed
the
DH-21375-databars-need-to-be-integrated-with-ui-table-format
branch
from
413b901 to
dbeccb8
Compare
| > [!WARNING] | ||
| > Migrating from the `databars` parameter | ||
| > | ||
| > The legacy `databars` parameter is deprecated and will be removed in a future version. Use `format_` with `mode=ui.TableDatabar()` instead. |
Contributor
There was a problem hiding this comment.
if gplus, maybe specific next version; if not, future version it is!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of DH-21375. Adds support for databars in
ui.TableFormatviamodeparameter. The legacydatabarsparameter is still supported but will show a deprecation warning.Changes:
There are some validation rules/warnings to be aware of while we maintain backwards compatibility with the old API
databarsprop andmode=TableDatabar()cant be used togethercolumnscan't be specified using the new api (should come fromTableFormat.cols)Most of these rules exist to support the old api, so we will have to clean them up once it's fully deprecated.