test: DH-20399: Add statistics-checking to RowGroup unit test#7664
Merged
robbcamera merged 7 commits intodeephaven:mainfrom Feb 13, 2026
Merged
test: DH-20399: Add statistics-checking to RowGroup unit test#7664robbcamera merged 7 commits intodeephaven:mainfrom
robbcamera merged 7 commits intodeephaven:mainfrom
Conversation
Contributor
No docs changes detected for 287d7b8 |
robbcamera
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
reviewed
Feb 9, 2026
devinrsmith
reviewed
Feb 10, 2026
devinrsmith
reviewed
Feb 11, 2026
| @SuppressWarnings("SimplifiableAssertion") | ||
| private static void assertMinStatisticsEquals(final Table sourceTable, final long row, | ||
| final List<ColumnChunkMetaData> columnMetadata) { | ||
| if (columnMetadata.get(0).getStatistics().hasNonNullValue()) { |
Member
There was a problem hiding this comment.
Caller should pass in hasAStats, hasBStats, etc, and we can explicitly assert whether hasNonNullValue matches that (and then conditionally, do the equals).
| @SuppressWarnings("SimplifiableAssertion") | ||
| private static void assertMaxStatisticsEquals(final Table sourceTable, final long row, | ||
| final List<ColumnChunkMetaData> columnMetadata) { | ||
| if (columnMetadata.get(0).getStatistics().hasNonNullValue()) { |
devinrsmith
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.