refactor(cli): remove dead formatLogLine helper - #6209
Open
pedrofrxncx wants to merge 1 commit into
Open
Conversation
pedrofrxncx
enabled auto-merge (squash)
August 18, 2026 21:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Net code reduction: -25 / +0.
formatLogLine(apps/api/src/cli/format-log-line.ts) was added in #3583 to tee intercepted console output into thedeco linklog file. Thedeco linkCLI command and its log-teeing path have since been fully removed (there's nolinksubcommand left inapps/api/src/cli.ts, nostartLinkDaemon, nolink.logreference anywhere in the tree).formatLogLinewas left behind with zero remaining callers —rg -n "formatLogLine"across the repo only turns up its own definition and its own test file.This PR deletes the dead helper and its test.
How I confirmed behavior is unchanged:
rg -n "formatLogLine"shows no other references anywhere in the repo (checked before deleting). Pure removal of unused code — nothing else calls it.Reviewer check:
rg -n "formatLogLine"on main should show the same two hits (definition + test) that this PR removes, and no other callers.Locally verified:
bun run fmt,cd apps/api && bunx tsc --noEmit(clean). No test to run since the deleted code had no other consumers — full CI covers the rest.Summary by cubic
Removes the dead
formatLogLinehelper and its test from the CLI; it was only used by the now-removeddeco linklog tee, so this has no runtime effect.rg -n "formatLogLine"onmainonly finds the deleted definition and test.deco linkpath is gone: nolinksubcommand,startLinkDaemon, orlink.logreferences remain.bun run fmtandbunx tsc --noEmitpass.Written for commit 56f5866. Summary will update on new commits.