fix: disable the Green Tea GC experiment (GOEXPERIMENT=greenteagc)#2538
Open
Isteb4k wants to merge 1 commit into
Open
fix: disable the Green Tea GC experiment (GOEXPERIMENT=greenteagc)#2538Isteb4k wants to merge 1 commit into
Isteb4k wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disable the Green Tea GC experiment (
GOEXPERIMENT=greenteagc) that is bakedinto the container-factory ALT golang toolchain when building KubeVirt Go
binaries. A single
export GOEXPERIMENT=nogreenteagcis added to the buildsetupstep inimages/virt-artifact/werf.inc.yaml, so it applies to allKubeVirt binaries (notably
virt-handlerandvirt-launcher, which host thelive-migration TLS proxy).
This drops only the GC experiment; the toolchain version and the ALT base image
(and therefore the CVE mitigation from
cc5aff898) are left untouched.Checklist
Changelog entries