[dmt] fix helmignore missing chart dirs#433
Merged
Merged
Conversation
diyliv
force-pushed
the
fix/helmignore-missing-chart-dirs
branch
from
July 20, 2026 07:49
de59a7d to
4fe8cb3
Compare
Signed-off-by: diyliv <onlogn081@gmail.com>
diyliv
force-pushed
the
fix/helmignore-missing-chart-dirs
branch
from
July 20, 2026 08:21
4fe8cb3 to
ea33f38
Compare
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
ldmonster
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monitoring/tomoduleTemplateExclude: themonitoring/directory contains Grafana dashboards and Prometheus rules that are rendered by Helm templates. It MUST be in the chart — listing it in.helmignorewould break the module.moduleTemplateExcludegrouping: "required by Helm" vs "read by Deckhouse directly".monitoring/being skipped, added test verifying that onlytemplates/,charts/,monitoring/are exempt from.helmignore(other dirs likedocs/,crds/,hooks/,openapi/correctly require.helmignoreentries).Context
The
checkModuleRootCoveragecheck scans the module root and warns about any file/directory not listed in.helmignore— except those inmoduleTemplateExclude. The exemption list was missingmonitoring/, causing false warnings:monitoring/is referenced bytemplates/monitoring.yamlviahelm_lib_prometheus_rules_recursionandhelm_lib_grafana_dashboards_recursion. Adding it to.helmignorebreaks chart rendering.Directories like
docs/,crds/,hooks/,openapi/correctly trigger warnings — Deckhouse reads them directly from the module filesystem, not from the rendered Helm chart. They should be in.helmignoreto keep the chart lean.Example
Before (false warning):
After: