Skip to content

[dmt] fix helmignore missing chart dirs#433

Merged
ldmonster merged 3 commits into
mainfrom
fix/helmignore-missing-chart-dirs
Jul 21, 2026
Merged

[dmt] fix helmignore missing chart dirs#433
ldmonster merged 3 commits into
mainfrom
fix/helmignore-missing-chart-dirs

Conversation

@diyliv

@diyliv diyliv commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add monitoring/ to moduleTemplateExclude: the monitoring/ directory contains Grafana dashboards and Prometheus rules that are rendered by Helm templates. It MUST be in the chart — listing it in .helmignore would break the module.
  • Clearer comments on moduleTemplateExclude grouping: "required by Helm" vs "read by Deckhouse directly".
  • Updated unit tests: added test for monitoring/ being skipped, added test verifying that only templates/, charts/, monitoring/ are exempt from .helmignore (other dirs like docs/, crds/, hooks/, openapi/ correctly require .helmignore entries).

Context

The checkModuleRootCoverage check scans the module root and warns about any file/directory not listed in .helmignore — except those in moduleTemplateExclude. The exemption list was missing monitoring/, causing false warnings:

WARN Directory 'monitoring/' is not listed in .helmignore

monitoring/ is referenced by templates/monitoring.yaml via helm_lib_prometheus_rules_recursion and helm_lib_grafana_dashboards_recursion. Adding it to .helmignore breaks chart rendering.

Directories like docs/, crds/, hooks/, openapi/ correctly trigger warnings — Deckhouse reads them directly from the module filesystem, not from the rendered Helm chart. They should be in .helmignore to keep the chart lean.

Example

Before (false warning):

WARN Directory 'monitoring/' is not listed in .helmignore

After:

(monitoring/ is skipped — needed for chart rendering)
(successful lint)

@diyliv diyliv changed the title fix helmignore missing chart dirs [dmt] fix helmignore missing chart dirs Jul 20, 2026
@diyliv diyliv self-assigned this Jul 20, 2026
@diyliv
diyliv requested a review from ldmonster July 20, 2026 07:41
@diyliv
diyliv force-pushed the fix/helmignore-missing-chart-dirs branch from de59a7d to 4fe8cb3 Compare July 20, 2026 07:49
@diyliv diyliv added bug Something isn't working go Pull requests that update go code labels Jul 20, 2026
Signed-off-by: diyliv <onlogn081@gmail.com>
@diyliv
diyliv force-pushed the fix/helmignore-missing-chart-dirs branch from 4fe8cb3 to ea33f38 Compare July 20, 2026 08:21
diyliv added 2 commits July 20, 2026 12:09
Signed-off-by: diyliv <onlogn081@gmail.com>
Signed-off-by: diyliv <onlogn081@gmail.com>
@ldmonster
ldmonster merged commit 5f78558 into main Jul 21, 2026
5 checks passed
@ldmonster
ldmonster deleted the fix/helmignore-missing-chart-dirs branch July 21, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants