fix: make disable() namespaces round-trip through enable() - #1051
Open
arronKler wants to merge 1 commit into
Open
fix: make disable() namespaces round-trip through enable()#1051arronKler wants to merge 1 commit into
arronKler wants to merge 1 commit into
Conversation
Historic enable() compiled '*' to '.*?'. disable() only inverted a trailing wildcard, so patterns like "*:error:*" came back as ".*?:error:*" and enable() rejected them. Normalize that encoding so enable(disable()) accepts mid-string wildcards and skip namespaces. Fixes debug-js#918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable(disable())should restore the same namespaces, including mid-string wildcards and skip patterns.disable()historically rebuilt the namespace string from compiled regexes and only inverted a trailing.*?. A pattern such as*:error:*came back as.*?:error:*, whichenable()then rejected (Invalid regular expression: Nothing to repeat).Normalize that historic
.*?encoding back to*when enabling and when rebuilding the disable() string, so the documented temporary-disable round-trip works for wildcards and skips.Fixes #918