Remove unused itest.cpp test driver.#211
Merged
Merged
Conversation
The file was excluded from the dtest build, had no Bazel target, and referenced a nonexistent realMain entry point. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the unused itest.cpp test driver and aligns the Bazel test source glob and documentation to reflect that only dtest is supported.
Changes:
- Deleted
library/tests/itest.cpp, which referenced arealMainentry point that does not exist in the codebase. - Updated
library/tests/BUILD.bazelto stop excludingitest.cppfrom thetest_sourcesfilegroup (since the file is now removed). - Updated
library/tests/args.hppdocumentation to remove mention of the removeditestdriver.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
library/tests/itest.cpp |
Removes an unused test driver with a nonexistent entry point. |
library/tests/BUILD.bazel |
Simplifies the test_sources exclude list now that itest.cpp is gone. |
library/tests/args.hpp |
Updates docs to describe args.hpp as supporting dtest only. |
zzcgumn
approved these changes
Jun 27, 2026
zzcgumn
left a comment
zzcgumn
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for cleaning this up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file was excluded from the dtest build, had no Bazel target, and referenced a nonexistent realMain entry point.