Fix debug_all builds#209
Draft
tameware wants to merge 2 commits into
Draft
Conversation
Dereference the transposition-table NodeCards pointer to match the DumpRetrieved(const NodeCards&) signature when DDS_AB_HITS is enabled. Co-authored-by: Cursor <cursoragent@cursor.com>
Re-add the DDS_AB_HITS dump helpers in dump.cpp so debug_all links succeed when ab_search logs transposition-table hits. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes --define=debug_all=true builds by ensuring the transposition-table “hits” debug dump functions are available (and correctly invoked) when DDS_AB_HITS is enabled via DDS_DEBUG_ALL.
Changes:
- Include
<utility/debug.h>indump.cppsoDDS_AB_HITSis consistently enabled in that translation unit fordebug_allbuilds. - Add
DDS_AB_HITS-guarded definitions forDumpRetrievedandDumpStoredto match existing declarations and call sites. - Update
ab_search.cppto pass aNodeCardsreference (*cardsP) toDumpRetrieved, matching the declared signature.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| library/src/dump.cpp | Enables/defines DDS_AB_HITS dump helpers in the TU so debug_all links successfully. |
| library/src/ab_search.cpp | Fixes DumpRetrieved invocation to pass NodeCards by reference instead of pointer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #200