Skip to content

Fix release pin sed delimiter - #95

Merged
dceoy merged 1 commit into
mainfrom
agent/fix-release-pin-sed
Aug 17, 2026
Merged

Fix release pin sed delimiter#95
dceoy merged 1 commit into
mainfrom
agent/fix-release-pin-sed

Conversation

@dceoy

@dceoy dceoy commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • use a non-conflicting sed delimiter when updating reusable workflow pins
  • avoid treating the version comment # or the (bot|review) alternation as the substitution delimiter

Root cause

The post-release workflow used # as the sed delimiter while also emitting # ${RELEASE_TAG} in the replacement text, causing sed: unknown option to 's'.

Validation

  • reproduced the failing expression locally
  • verified the replacement with , as the delimiter updates the pinned SHA and version comment correctly
  • branch diff is limited to one line in .github/workflows/post-release.yml

@dceoy
dceoy marked this pull request as ready for review August 17, 2026 17:23
@dceoy dceoy self-assigned this Aug 17, 2026

@dceoy dceoy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the one-line workflow fix. No actionable issues found. The delimiter change avoids conflicts with both the literal version-comment # and the (bot|review) alternation, while preserving the existing match-count guards and replacement behavior. CI/CD passes on the reviewed head commit.

@dceoy
dceoy merged commit c74c81f into main Aug 17, 2026
15 of 17 checks passed
@dceoy
dceoy deleted the agent/fix-release-pin-sed branch August 17, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant