Remove root agent instruction files - #94
Conversation
|
OpenCode PR Review: 0 inline finding(s), 2 summary-only finding(s).
|
There was a problem hiding this comment.
Reviewed with a multi-agent pass (code-quality, performance, test-coverage, documentation-accuracy, security).
Mechanically clean. CLAUDE.md (a symlink to AGENTS.md) and its target are deleted together — no dangling symlink, and no CI workflow, script, or test references either path directly. No runtime/perf/test/security-control impact.
One convergent concern (code-quality, documentation-accuracy, and security reviewers all flagged variants of this): the deleted content isn't relocated anywhere. AGENTS.md was the only place documenting several concrete, non-obvious repo conventions:
- "Review-routing changes must update the skill, orchestrator allow-list, agent files, regression tests, and user documentation together" — no other file states this dependency chain.
- The
action.yml→README.mdsync rule. - Coding conventions (kebab-case inputs, pinned-SHA actions with version comment,
bash -euo pipefailrequirement). - The "Security & Configuration Tips" summary and
/review-prtrust-boundary note.
None of this is duplicated in README.md, docs/, or the nested .opencode/agents/*.md files — those only generically instruct reviewers to "check applicable AGENTS.md" for whatever repo they're reviewing, not restate this repo's own guidance. The security-relevant trust-boundary detail specifically is still covered separately in docs/pull-request-reviews.md and docs/custom-providers.md (untouched by this PR), so nothing security-critical is silently lost — but the contributor-facing process/style guidance has no home after this merges, and the PR description ("no runtime code changes") doesn't mention this tradeoff.
Suggest either folding the still-relevant parts into CONTRIBUTING.md/docs/ before merging, or noting explicitly in the PR description that this guidance is being intentionally dropped rather than relocated.
No other findings — performance and test-coverage reviewers found nothing noteworthy.

Summary
AGENTS.mdCLAUDE.mdImpact
Checks