Skip to content

Remove root agent instruction files - #94

Merged
dceoy merged 2 commits into
mainfrom
agent/remove-root-agent-instructions
Aug 16, 2026
Merged

Remove root agent instruction files#94
dceoy merged 2 commits into
mainfrom
agent/remove-root-agent-instructions

Conversation

@dceoy

@dceoy dceoy commented Aug 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove repository-root AGENTS.md
  • remove repository-root CLAUDE.md

Impact

  • no runtime code changes
  • nested agent instruction files are unchanged

Checks

  • verified only repository-root instruction files are removed

@dceoy
dceoy marked this pull request as ready for review August 16, 2026 16:05
@opencode-agent

Copy link
Copy Markdown

OpenCode PR Review: 0 inline finding(s), 2 summary-only finding(s).

  • important · code-reviewer.opencode/agents/code-reviewer.md:36
    This agent instruction file still tells reviewers to check code against AGENTS.md, but the root AGENTS.md file is deleted in this PR. After the deletion, the reference points to a non-existent file, so the instruction is misleading and unmaintainable.

    Update or remove the reference to AGENTS.md in this file, e.g., point it at the appropriate nested instruction files or drop the bullet if root guidelines no longer apply.

  • important · documentation-accuracy-reviewer.opencode/agents/silent-failure-hunter.md:109
    After this PR deletes AGENTS.md, this agent instruction still directs the reviewer to "Check AGENTS.md for the project's error-handling conventions". That file will no longer exist anywhere in the repository, so the instruction is stale and will send agents/maintainers to a missing file.

    Update the line to reference the actual remaining repository-local guidance, for example: "Check repository-local instructions for the project's error-handling conventions, for example:".

New%20session%20-%202026-08-16T16%3A05%3A32.422Z
opencode session  |  github run

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed with a multi-agent pass (code-quality, performance, test-coverage, documentation-accuracy, security).

Mechanically clean. CLAUDE.md (a symlink to AGENTS.md) and its target are deleted together — no dangling symlink, and no CI workflow, script, or test references either path directly. No runtime/perf/test/security-control impact.

One convergent concern (code-quality, documentation-accuracy, and security reviewers all flagged variants of this): the deleted content isn't relocated anywhere. AGENTS.md was the only place documenting several concrete, non-obvious repo conventions:

  • "Review-routing changes must update the skill, orchestrator allow-list, agent files, regression tests, and user documentation together" — no other file states this dependency chain.
  • The action.ymlREADME.md sync rule.
  • Coding conventions (kebab-case inputs, pinned-SHA actions with version comment, bash -euo pipefail requirement).
  • The "Security & Configuration Tips" summary and /review-pr trust-boundary note.

None of this is duplicated in README.md, docs/, or the nested .opencode/agents/*.md files — those only generically instruct reviewers to "check applicable AGENTS.md" for whatever repo they're reviewing, not restate this repo's own guidance. The security-relevant trust-boundary detail specifically is still covered separately in docs/pull-request-reviews.md and docs/custom-providers.md (untouched by this PR), so nothing security-critical is silently lost — but the contributor-facing process/style guidance has no home after this merges, and the PR description ("no runtime code changes") doesn't mention this tradeoff.

Suggest either folding the still-relevant parts into CONTRIBUTING.md/docs/ before merging, or noting explicitly in the PR description that this guidance is being intentionally dropped rather than relocated.

No other findings — performance and test-coverage reviewers found nothing noteworthy.

@dceoy
dceoy merged commit 7c5dff7 into main Aug 16, 2026
18 of 19 checks passed
@dceoy
dceoy deleted the agent/remove-root-agent-instructions branch August 16, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant