Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/claude.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ jobs:
if: >
github.event_name == 'pull_request'
&& (! github.event.pull_request.draft)
&& (! startsWith(github.head_ref, 'dependabot/'))
&& (! startsWith(github.head_ref, 'renovate/'))
&& github.event.pull_request.user.type != 'Bot'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep branch checks for non-App automation accounts

When self-hosted Renovate authenticates through a PAT or machine-user account, the PR author is reported as type: User even though its branch still uses the renovate/ prefix. Replacing the branch guards solely with this type check therefore makes the Claude review run again for those automated PRs; the same regression occurs in .github/workflows/opencode-review.yml:121 when that account has a trusted author association. Retain the Dependabot/Renovate branch exclusions alongside the generic Bot check.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion · workflow-condition-correctness

The new github.event.pull_request.user.type != 'Bot' check skips GitHub App bots (including Dependabot and the hosted Mend Renovate app), but it does not cover self-hosted Renovate authenticated with a personal access token. Those PRs still use renovate/* branches but are authored by a regular user account (user.type == 'User'), so the previous startsWith(github.head_ref, 'renovate/') guard caught them and the new check does not.

This causes the Claude Code review job (and the OpenCode review job in .github/workflows/opencode-review.yml) to run on PAT-based Renovate PRs, wasting CI resources and potentially posting unwanted reviews.

Consider keeping both checks:

      && github.event.pull_request.user.type != 'Bot'
      && (! startsWith(github.head_ref, 'renovate/'))

permissions:
contents: read
pull-requests: write
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/opencode-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ jobs:
if: >
(
(github.event_name == 'issue_comment' || github.event_name == 'pull_request_review_comment')
&& github.event.comment.user.type != 'Bot'
&& contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)
&& (
inputs.model != ''
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/opencode-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ jobs:
|| (
contains(fromJSON('["OWNER","MEMBER","COLLABORATOR"]'), github.event.pull_request.author_association)
&& (! github.event.pull_request.draft)
&& (! startsWith(github.head_ref, 'dependabot/'))
&& (! startsWith(github.head_ref, 'renovate/'))
&& github.event.pull_request.user.type != 'Bot'
)
)
runs-on: ${{ inputs.runs-on || 'ubuntu-latest' }}
Expand Down
Loading