Transform identifiers to look like idiomatic JavaScript#81
Draft
oleavr wants to merge 1 commit intodbusjs:masterfrom
Draft
Transform identifiers to look like idiomatic JavaScript#81oleavr wants to merge 1 commit intodbusjs:masterfrom
oleavr wants to merge 1 commit intodbusjs:masterfrom
Conversation
Where names of properties, methods, and signals are in camelCase instead of PascalCase.
Member
|
This is a great idea and I would love to merge this, but it would break every application that uses this library, so I can't. Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where names of properties, methods, and signals are in camelCase instead
of PascalCase.
I don't know if this would be an acceptable direction to go in, so I didn't
update the tests – but happy to do that if this is of interest.