Skip to content

Generalized fetching of uid and add support for DBUS_UID env var#76

Open
martenjacobs wants to merge 1 commit intodbusjs:masterfrom
martenjacobs:master
Open

Generalized fetching of uid and add support for DBUS_UID env var#76
martenjacobs wants to merge 1 commit intodbusjs:masterfrom
martenjacobs:master

Conversation

@martenjacobs
Copy link
Contributor

Solves #75

@acrisci
Copy link
Member

acrisci commented May 20, 2021

I don't like the idea of an env var. Does process.getuid() not give you the right value?

@martenjacobs
Copy link
Contributor Author

I don't like the idea of an env var. Does process.getuid() not give you the right value?

No it doesn’t, because the process is running under macOS and is connecting to DBus on another machine through TCP.
A nicer solution could be to add the uid to the params of the bus constructor. I just choose the env var approach because it was simpler to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants