Change argument order for add/remove match exist check#126
Closed
ianchanning wants to merge 1 commit intodbusjs:masterfrom
Closed
Change argument order for add/remove match exist check#126ianchanning wants to merge 1 commit intodbusjs:masterfrom
ianchanning wants to merge 1 commit intodbusjs:masterfrom
Conversation
Attempts to correct logic to intended behaviour. That is, check existing property `match` on `this._matchRules` instead of `this._matchRules` on `match`.
Author
|
Sorry - github defaulted to the original repo went I wanted to merge into personal fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to correct logic to intended behaviour. That is, check existing property
matchonthis._matchRulesinstead ofthis._matchRulesonmatch.Copy of #110