ci: run unit and integration tests on release branches - #797
Merged
Conversation
Both workflows filtered on `branches: [master, v*]`. GitHub matches the whole ref, so `v*` matches a branch literally named `v1.11` but not `release/v1.11` — the naming this repo actually uses. Pull requests targeting a release branch therefore ran pre-commit only: no unit tests and no integration matrix. That left backports as the least-tested changes in the repo, despite shipping first. #791 and #794 currently have no test coverage at all. Adding `release/**` to the push and pull_request filters of both workflows. Stacked pull requests (base is a feature branch rather than master or a release branch) are still uncovered by design; those are validated once rebased, or by dispatching the workflow against the branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both workflows filter on
branches: [master, v*]. GitHub matches the whole ref, sov*matches a branch literally namedv1.11— notrelease/v1.11, which is the naming this repo uses.The effect is that a pull request targeting a release branch runs pre-commit only. No unit tests, no integration matrix. Backports are therefore the least-tested changes in the repo despite shipping first: #791 and #794 have no test coverage at all right now, and the 1.11 release would ship those fixes validated solely by their master-side counterparts.
Adds
release/**to thepushandpull_requestfilters ofunit-tests.ymlandintegration-tests-sqlserver.yml.Stacked pull requests — where the base is a feature branch rather than
masteror a release branch — remain uncovered. That is not fixable with a branch filter, since the base can be any branch name; those are validated once rebased ontomaster, or by dispatching the workflow against the branch (gh workflow run "Integration tests on SQL Server" --ref <branch>).No milestone: CI-only, ships with whatever release is current.