Skip to content

dbeaver/pro#6324 sync view with selection #3637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devnaumov wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

dbeaver/pro#6324 sync view with selection #3637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4c1c6e
dbeaver/pro#6324 sync view with selection
devnaumov Aug 5, 2025
6b8425e
Merge branch 'devel' into dbeaver/pro#6324-cursor-sync
dariamarutkina Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion webapp/packages/plugin-codemirror6/src/ReactCodemirror.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
}

return () => {};
}, [container, incomingValue !== undefined]);

Check warning on line 161 in webapp/packages/plugin-codemirror6/src/ReactCodemirror.tsx

View workflow job for this annotation

GitHub Actions / Frontend / Lint 

React Hook useLayoutEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked

Check warning on line 161 in webapp/packages/plugin-codemirror6/src/ReactCodemirror.tsx

View workflow job for this annotation

GitHub Actions / Frontend / Lint 

React Hook useLayoutEffect has missing dependencies: 'callbackRef', 'cursor', 'extensions', 'incomingValue', and 'value'. Either include them or remove the dependency array

useLayoutEffect(() => {
if (!view) {
Expand Down Expand Up @@ -226,7 +226,10 @@
}

if (transaction.selection) {
view.dispatch({ selection: transaction.selection });
view.dispatch({ selection: transaction.selection, scrollIntoView: true });
if (!view.hasFocus) {
view.focus();
}
Comment on lines +229 to +232
Copy link
Copy Markdown
Member

@Wroud Wroud Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may lead to unexpected behaviour

}
}
});
Expand Down
2 changes: 1 addition & 1 deletion webapp/packages/plugin-sql-editor/src/SqlEditor/SqlEditorTools.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export const SqlEditorTools = observer<Props>(function SqlEditorTools({ data, st
}
}

async function downloadScriptHandler() {
function downloadScriptHandler() {
tools.downloadScript(data.value.trim());
}

Expand Down
5 changes: 5 additions & 0 deletions webapp/packages/plugin-system-information-administration/src/SystemInformation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
useObjectPropertyCategories,
GroupTitle,
Container,
TextPlaceholder,
} from '@cloudbeaver/core-blocks';
import type { TabContainerPanelComponent } from '@cloudbeaver/core-ui';
import { SystemInformationResource } from './SystemInformationResource.js';
Expand All @@ -44,6 +45,10 @@ export const SystemInformation: TabContainerPanelComponent<AdministrationItemCon
}
}

if (!properties.length) {
return <TextPlaceholder>{translate('ui_no_items_placeholder')}</TextPlaceholder>;
}

return (
<ColoredContainer overflow parent>
<Group gap medium wrap>
Expand Down
Loading