Formatting. Base classes. Missing properties.#23
Formatting. Base classes. Missing properties.#23drauggres wants to merge 8 commits intodbankier:masterfrom
Conversation
move common methods to base classes add "hide" method add "release" method
|
Amazing. I will review this soon. Thank you very much. |
|
This PR fixed a problem that I was having on 7.3.1 version of Titanium. Change the TimePickerProxy.java#L78: Change the MultiPickerProxy.java:
Had also to import the TiApplication on each file. |
|
Thank you @javamanrj. I've updated PR. |
.clang-formatstyle file and all sources are formatted using it (this is default style and now it is included in android module template)BaseUIDialogandBaseDialogProxy.BaseUIDialogimplementshideandreleasemethods, so now we can callhideon proxy and dialog will be hidden.minDate,maxDate,format24.cancelevent is fired on dialog dismiss (we can catchbackbutton)P.S. Main goal of this changes is to have ability to hide dialog (which is not provided in SDK).