Open
Conversation
…Angular, React, and Vue
…ort across all showcases
…hevron and slash styles
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…-konzept-design-für-alle-frameworks
… mitosis-problems with helper
…al development" This reverts commit e73fbe1.
Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
…g based on environment
…y ellipsis aria label
…omponentVariants types
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
- Updated breadcrumb.scss to enhance separator handling for both HTML and Angular implementations. - Removed deprecated breadcrumb-item and breadcrumb components from Angular showcase. - Introduced new showcase components for breadcrumb and breadcrumb-item in Angular. - Added new examples for breadcrumb and breadcrumb-item in React and Vue showcases. - Implemented Storybook arg types for breadcrumb and breadcrumb-item components. - Created showcase files for various breadcrumb examples including size, separator, and icons.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…isabled links
- Import getBooleanAsString from utils (consistent with link.lite.tsx)
- Set aria-disabled={getBooleanAsString(props.disabled)} so screen readers
correctly announce the disabled state
- Set tabIndex={-1} when disabled to remove the link from keyboard tab order
Previously only pointerEvents:none was set, which blocked mouse clicks but
still allowed keyboard users to Tab to and activate the link.
sarahbrng
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(breadcrumb): Add DBBreadcrumb and DBBreadcrumbItem MVP components
Problem
Features
small(default) undmediumchevron(default) undslashmaxItems; interaktiver Ellipsis-Button mitellipsisAriaLabelitems-Array (empfohlen) oder manuelleDBBreadcrumbItemChild-Components mithref,text,icon,ariaCurrent,disabledWorkarounds
<ol>→<li>-Struktur; UX bleibt vollständig accessibleCUSTOM_ELEMENTS_SCHEMA; temporärer Import-Workaround in BreadcrumbItem; Post-Build Overwrites für Non-Null-Assertions beimaxItems/items(TypeScript strict mode)Changes
DBBreadcrumbcomponent: supportssize(small/medium),separator(chevron/slash),maxItemswith collapsible ellipsis behavior,ellipsisAriaLabel, and data-drivenitemspropDBBreadcrumbItemcomponent: supportstext,icon,ariaCurrent,size; uses lite imports throughoutaria-disabled+tabIndex={-1}added on disabled<a>elements — previously onlypointerEvents:nonewas set, allowing keyboard users to still reach disabled itemsDBBreadcrumbIteminternalListIdstate added for robust list ID managementAffected Areas
packages/components/src/components/breadcrumb*— new component source, models, styles, specsshowcases/(angular, react, vue, e2e, patternhub) — showcase integration and navigation entriesBreaking Changes: none — new components only
Risk: low — isolated new feature, no modifications to existing components
Validated: visual snapshots regenerated across chromium, firefox, webkit, mobile-chrome, mobile-safari; ARIA and a11y tests passing
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/1493-erstellung-einer-mvp-breadcrumb-komponente