A better suggestion about the annotation usage#60
Open
WilliamSESE wants to merge 1 commit intodavpin:masterfrom
Open
A better suggestion about the annotation usage#60WilliamSESE wants to merge 1 commit intodavpin:masterfrom
WilliamSESE wants to merge 1 commit intodavpin:masterfrom
Conversation
Hi, I found that there may be some minor improvements about annotations in your code. A Spring bean in the service layer should be annotated using @service instead of @component annotation. @service annotation is a specialization of @component in service layer. By using a specialized annotation we hit two birds with one stone. First, they are treated as Spring bean, and second, you can put special behavior required by that layer. For better understanding and maintainability of a large application, @service is a better choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I found that there may be some minor improvements about annotations in your code.
A Spring bean in the service layer should be annotated using @service instead of @component annotation.
@service annotation is a specialization of @component in service layer. By using a specialized annotation we hit two birds with one stone. First, they are treated as Spring bean, and second, you can put special behavior required by that layer.
For better understanding and maintainability of a large application, @service is a better choice.