fix: enable input method switching under Wayland#2278
Open
breakatop wants to merge 1 commit intodavatorium:nextfrom
Open
fix: enable input method switching under Wayland#2278breakatop wants to merge 1 commit intodavatorium:nextfrom
breakatop wants to merge 1 commit intodavatorium:nextfrom
Conversation
breakatop
commented
Mar 25, 2026
breakatop
commented
- Release the shortcut Control+Space for switching input methods; change the original Control+Space to Alt+Return.
- Implement pre‑edit, commit, and delete, allowing fcitx5 to function properly.
Collaborator
|
I've tested it and there is a bad interaction with the Input method switching appears on the top-left of the screen instead of where the text input is. Problem disappears with But it's not exactly a problem with these changes I suppose, maybe acceptable as a first solution |
lbonn
reviewed
Apr 12, 2026
| zwp_text_input_v3_commit(text_input); | ||
| } | ||
| static void text_input_leave(void *data, struct zwp_text_input_v3 *text_input, | ||
| struct wl_surface *surface) { |
Collaborator
There was a problem hiding this comment.
What happened with these indentation changes? Better leave them aligned as clang-format does. Also in text_input_commit_string
| {.id = ROW_SELECT, | ||
| .name = "kb-row-select", | ||
| .binding = "Control+space", | ||
| .binding = "Alt+Return", |
Collaborator
There was a problem hiding this comment.
To change in doc/rofi-keys.5.markdown.
Maybe Alt+space is closer to the original binding, not sure what's the most intuitive here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.