fix: add metrics auth RBAC to rbac_deployment component#79
Merged
Conversation
Add metrics_auth_role and metrics_auth_role_binding to the rbac_deployment kustomize Component so the operator SA can perform TokenReview and SubjectAccessReview for metrics authentication. Without this RBAC, the controller-runtime metrics filter cannot validate bearer tokens from VMAgent, causing all scrape requests to fail with 401.
JoseSzycho
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metrics_auth_role.yamlandmetrics_auth_role_binding.yamlto theconfig/rbac_deployment/kustomize Componenttokenreviewsandsubjectaccessreviews, which controller-runtime's metrics filter needs to validate bearer tokens from VMAgentContext
The
rbac_deploymentcomponent is used by the infra repo's Flux Kustomization to deploy RBAC alongside the operator. The existingconfig/rbac/directory includes these files but is not used in the deployment path (config/manager+config/rbac_deployment).Without this RBAC, the metrics filter returns 401 for all scrape requests because it cannot call the TokenReview API.
Test plan
upin VMAgent targets