chore: add metrics service to prometheus component#78
Merged
Conversation
scotwells
force-pushed
the
chore/add-metrics-service-to-prometheus-component
branch
from
38f6cc5 to
46812af
Compare
Include metrics_service.yaml in the prometheus kustomize Component so that deploying with the prometheus component provides both the ServiceMonitor and the matching Service for metrics scraping. Add app.kubernetes.io/name selector to Service and ServiceMonitor to uniquely target this operator's pods in shared namespaces.
scotwells
force-pushed
the
chore/add-metrics-service-to-prometheus-component
branch
2 times, most recently
from
0c774c8 to
3e2017a
Compare
ecv
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metrics_service.yamlto the prometheus kustomize Component resourcespath: managerwith../prometheusas a component, the ServiceMonitor is deployed but the matching metrics Service is missingTest plan
kustomize build config/managerwith the prometheus component includes both ServiceMonitor and metrics Service