chore: Remove unused vmtap-cni plugin - #440
Merged
Merged
Conversation
vmtap-cni was never deployed to any real cluster and had no consumers of internal/vmtap outside its own binary — it was dead weight shipped in every galactic-cni image build for a Unikraft/kraftlet integration that was never wired up (config/vmtap-cni/'s node-affinity label was itself a documented placeholder). Removes cmd/vmtap-cni, internal/vmtap, config/vmtap-cni, and docs/vmtap-cni, drops the binary from the Taskfile build target and the galactic-cni Dockerfile's build/copy stages, drops the vmtap-cni kustomize resource, and updates every doc/comment cross-reference (README, AGENTS.md/CLAUDE.md, both ARCHITECTURE docs, the C4 container diagram, and two source comments that pointed at the now-deleted package) accordingly. task build, task test:unit, and task lint all pass clean after the removal.
scotwells
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vmtap-cni was a standalone CNI plugin for wiring Unikraft microVMs into Cilium's own network chain, but it was never deployed to any real cluster and nothing outside its own binary depended on its package. This removes the plugin, its package, and its manifests, and updates every doc and comment that described it.
Test plan
task cipasses (lint, build, unit tests)