fix: Require manual rollout for BGP router DaemonSets - #439
Merged
Conversation
fabric-router and galactic-router are BGP speakers whose health checks only confirm the process is running, not that the BGP session has reconverged. Kubernetes was free to restart their pods automatically on any image or spec change, advancing to the next node before the previous one's session actually recovered. For galactic-router's route-reflector role, a restart drops every peer's session at once instead of just one node's. Both DaemonSets now require a manual pod delete to apply an update, and the README documents the rollout procedure and ordering. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
privateip
marked this pull request as ready for review
August 21, 2026 01:56
privateip
enabled auto-merge
August 21, 2026 01:57
scotwells
approved these changes
Aug 21, 2026
scotwells
left a comment
scotwells
left a comment
Contributor
There was a problem hiding this comment.
Wonder if readiness probes could be used to control the rollout? Maybe the readiness check could check convergence?
Contributor
Author
It can but thats not a reliable check. If the remote peer is not under our administrative control, it could cause sessions to be down and convergence to be partial but in reality our side is both properly configured and healthy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fabric-router and galactic-router are BGP speakers whose health checks only confirm the process is running, not that the BGP session has reconverged. Kubernetes was free to restart their pods automatically on any image or spec change, advancing to the next node before the previous one's session actually recovered. For galactic-router's route-reflector role, a restart drops every peer's session at once instead of just one node's. Both DaemonSets now require a manual pod delete to apply an update, and the README documents the rollout procedure and ordering.
Test plan