Skip to content

fix: always show safe mode badge including silent level#359

Open
eliottwantz wants to merge 1 commit intodatlechin:mainfrom
eliottwantz:bug/safe-mode-silent-icon
Open

fix: always show safe mode badge including silent level#359
eliottwantz wants to merge 1 commit intodatlechin:mainfrom
eliottwantz:bug/safe-mode-silent-icon

Conversation

@eliottwantz
Copy link
Contributor

@eliottwantz eliottwantz commented Mar 17, 2026

Remove conditional rendering of safe mode badge. The silent level should be displayed alongside other safe mode levels to ensure consistent UI and make the safe mode state always visible to users, even when set to silent.

Closes #358

Summary by CodeRabbit

  • Bug Fixes
    • Safe mode status indicator now always displays consistently, even when in silent mode, ensuring users can always see the current safe mode status without requiring additional interaction.

Remove conditional rendering of safe mode badge. The silent level should be displayed alongside other safe mode levels to ensure consistent UI and make the safe mode state always visible to users, even when set to silent.
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 59e528d0-dcec-4416-83e3-844698c864a4

📥 Commits

Reviewing files that changed from the base of the PR and between 9dc6597 and a6bf299.

📒 Files selected for processing (3)
  • TablePro/Models/Connection/ConnectionToolbarState.swift
  • TablePro/Views/Toolbar/ConnectionStatusView.swift
  • TablePro/Views/Toolbar/SafeModeBadgeView.swift

📝 Walkthrough

Walkthrough

Changes ensure the safe-mode icon, label, and button remain visible in the toolbar regardless of safe-mode level value, by removing conditional rendering and display logic that previously hid them when the level was "silent".

Changes

Cohort / File(s) Summary
Safe Mode Always-Visible
TablePro/Models/Connection/ConnectionToolbarState.swift, TablePro/Views/Toolbar/ConnectionStatusView.swift, TablePro/Views/Toolbar/SafeModeBadgeView.swift
Removed conditional guards that hid the safe-mode badge, label, and button when safeModeLevel equals .silent. The safe-mode icon and associated UI elements now render unconditionally regardless of safe-mode level value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • PR #250: Directly related as it introduced/modified the same UI components (ConnectionToolbarState, ConnectionStatusView, SafeModeBadgeView) that are being updated to fix the safe-mode visibility issue.

Poem

🐰 The icon that hid when silence fell now gleams,
No more vanishing tricks, just what it seems!
Safe mode shines through, forever on display,
Even whisper-quiet keeps the badge at bay. 🎖️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: removing conditional rendering to always display the safe mode badge including silent level.
Linked Issues check ✅ Passed The changes directly address issue #358 by removing conditional rendering that hid the safe mode badge when safeModeLevel was .silent, ensuring the icon is now always visible.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the safe mode badge visibility issue. No unrelated modifications or refactoring detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use Clang for C/C++ static analysis and code quality checks.

Clang provides comprehensive static analysis for C and C++ code, including syntax checking, type checking, and various warning diagnostics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: safe mode icon hidden when level is "silent"

1 participant