Skip to content

Add fastnda extractor#40

Merged
ml-evs merged 1 commit intodatatractor:mainfrom
g-kimbell:fastnda
Feb 4, 2026
Merged

Add fastnda extractor#40
ml-evs merged 1 commit intodatatractor:mainfrom
g-kimbell:fastnda

Conversation

@g-kimbell
Copy link
Contributor

Adds fastnda as an extractor for neware-nda files

@g-kimbell
Copy link
Contributor Author

@PeterKraus can you advise on this? I tried following the developer instructions but its a bit painful.

I cannot do --recurse-submodules without permissions.

I forked both yard and schema and changed .gitmodules, now I can run --recurse-submodules, and I can run invoke regenerate-models, but it still fails when I try running with uvicorn because it can't find a version. If i then fetch upstream tags i can pip install yard, but uvicorn still fails,

I also tried validating with schema:

linkml-validate -s schemas/extractor.yaml -C Extractor examples/fastnda.yml
No issues found

If i checkout main and run invoke validate-entries I get the same error in the build step of the CI

@ml-evs
Copy link
Member

ml-evs commented Feb 4, 2026

Hi @g-kimbell, none of that should be necessary, your linting/validate jobs have run correctly and there's just a build issue that doesn't seem related to your PR for us to fix.

For future reference, --recurse-submodules shouldn't need permissions, you just likely don't have SSH set up locally with git. This is a common problem but again shouldn't be necessary here.

@ml-evs
Copy link
Member

ml-evs commented Feb 4, 2026

It does look like we should make clearer the distinction between Contributing to the database (what you are doing), with instructions here: https://github.com/datatractor/yard/blob/main/CONTRIBUTING.md vs Development, which seems to be what you tried to do.

Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and the build is now passing after #41.

Thanks @g-kimbell!

@ml-evs ml-evs merged commit afe89aa into datatractor:main Feb 4, 2026
3 checks passed
@g-kimbell
Copy link
Contributor Author

Thanks @ml-evs, I thought the build failure was something on my end.

I see the SSH problem, I thought cloning with https would fix, but it didn't affect the submodules - works after setting up SSH on this machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants