feat: OpenCode support, performance improvements, WebSocket fix#68
Open
dgokeeffe wants to merge 5 commits intodatasciencemonkey:mainfrom
Open
feat: OpenCode support, performance improvements, WebSocket fix#68dgokeeffe wants to merge 5 commits intodatasciencemonkey:mainfrom
dgokeeffe wants to merge 5 commits intodatasciencemonkey:mainfrom
Conversation
- Install OpenCode from dgokeeffe/opencode fork with native Databricks provider (auto-discovers models, shares Claude Code skills) - Add GitHub CLI (gh) setup with xterm.js-safe auth wrapper - Reduce select() timeout 500ms→50ms and poll interval 100ms→50ms - Add Makefile for deployment automation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace single global sessions_lock block in get_output_batch() with 3-step resolve/swap/join pattern matching get_output(). Snapshot session dict in cleanup_stale_sessions() to iterate with per-session locks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Socket.IO sets connected=true even when falling back to its own long-polling (Databricks Apps proxy blocks WS upgrade). This stopped the fast poll-worker, routing all output through slow long-polling. Now checks socket.io.engine.transport.name and only stops poll-worker when transport is true 'websocket'. Also listens for late upgrades. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
reviewed
Mar 17, 2026
mpkrass7
requested changes
Mar 17, 2026
Move inline gh CLI installation from app.py into install_gh.sh, following the same pattern as install_micro.sh. The script now fetches the latest 2.x release from the GitHub API instead of pinning a specific version. Also fixes a bug in the gh wrapper where the auth login handler fell through to exec gh.real with shifted args instead of exiting after handling the command. Co-authored-by: Isaac
Add `make clean` to remove both the app and secret scope, helping with manual testing teardown. Add `make create-pat` to auto-generate a 90-day PAT via Databricks CLI and store it directly. Remove PAT from the usage example header to discourage passing secrets on the command line. Co-authored-by: Isaac
mpkrass7
reviewed
Mar 18, 2026
| # Sanitizes requests/responses between OpenCode and Databricks | ||
| # (see OpenCode #5028, docs/plans/2026-03-11-litellm-empty-content-blocks-design.md) | ||
| _run_step("proxy", ["python", "setup_proxy.py"]) | ||
| _run_step("proxy", ["uv", "run", "python", "setup_proxy.py"]) |
Collaborator
There was a problem hiding this comment.
For using UV run, we'll need to update dependabot to ensure it's using uv instead of pip for package management
mpkrass7
requested changes
Mar 18, 2026
Collaborator
mpkrass7
left a comment
There was a problem hiding this comment.
Ok two pieces of feedback before we merge:
Code: Remove UV change for now, we need to add dependabot changes and that should be in another PR
PR:
- Change the name to reflect what you are actually doing in this PR (e.g. add Makefile and remove OpenCode support)
- Change the tests to reflect what you are actually doing in this PR
- Do the tests. Deploy onto dogfood to test it
Collaborator
|
@dgokeeffe Let me know when you've deployed / tested your changes on dogfood. Once you confirm I'll test on my end and we can get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
This pull request was AI-assisted by Isaac.