fix: Check actual WebSocket transport before stopping poll-worker#59
Merged
datasciencemonkey merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Socket.IO reports connected=true even when falling back to HTTP long-polling through the Databricks Apps reverse proxy. The app was prematurely stopping the poll-worker, leaving users with no data transport when true WebSocket wasn't available. Now checks socket.io.engine.transport.name before deciding: - 'websocket' → stop poll-worker, use WS as primary - 'polling' → keep poll-worker active as primary transport - Listen for late 'upgrade' event if transport upgrades later Cherry-picked from PR #52 (dgokeeffe). Fixes #54 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Socket.IO reports
connected=trueeven when falling back to HTTP long-polling through the Databricks Apps reverse proxy. The app was prematurely stopping the poll-worker, leaving users with no data transport.Fix
Check
socket.io.engine.transport.namebefore deciding:'websocket'→ stop poll-worker, use WS as primary'polling'→ keep poll-worker active as primary transportupgradeevent if transport upgrades laterChanges
static/index.html— transport detection in Socket.IO connect handlerCherry-picked from PR #52 (dgokeeffe). Fixes #54.
🤖 Generated with Claude Code