Skip to content

Add missing @PreAuthorize to ProcessRestRepository#delete #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MatusBeke wants to merge 2 commits into
base: dtq-dev
Choose a base branch
from
Open

Add missing @PreAuthorize to ProcessRestRepository#delete #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd698ca
Add missing @PreAuthorize to ProcessRestRepository#delete
MatusBeke Jul 27, 2026
0fd6e57
Address review: rename param to id, add DELETE authz regression tests
MatusBeke Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dspace-server-webapp/src/main/java/org/dspace/app/rest/repository/ProcessRestRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,13 @@ public BitstreamRest getProcessBitstreamByType(Integer processId, String type)
}

@Override
protected void delete(Context context, Integer integer)
@PreAuthorize("hasPermission(#id, 'PROCESS', 'DELETE')")
protected void delete(Context context, Integer id)
throws AuthorizeException, RepositoryMethodNotImplementedException {
try {
processService.delete(context, processService.find(context, integer));
processService.delete(context, processService.find(context, id));
} catch (SQLException | IOException e) {
log.error("Something went wrong trying to find Process with id: " + integer, e);
log.error("Something went wrong trying to find Process with id: " + id, e);
throw new RuntimeException(e.getMessage(), e);
}
}
Expand Down
36 changes: 36 additions & 0 deletions dspace-server-webapp/src/test/java/org/dspace/app/rest/ProcessRestRepositoryIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import static org.hamcrest.Matchers.contains;
import static org.hamcrest.Matchers.containsInAnyOrder;
import static org.hamcrest.Matchers.is;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
Expand Down Expand Up @@ -126,6 +127,41 @@ public void getProcessForDifferentUserForbiddenException() throws Exception {

}

@Test
public void deleteProcessAdmin() throws Exception {
// "process" (from setup) is SCHEDULED with no bitstreams - the exact shape that
// previously bypassed authorization entirely.
String token = getAuthToken(admin.getEmail(), password);

getClient(token).perform(delete("/api/system/processes/" + process.getID()))
.andExpect(status().isNoContent());

getClient(token).perform(get("/api/system/processes/" + process.getID()))
.andExpect(status().isNotFound());
}

@Test
public void deleteProcessAnonymousUnauthorizedException() throws Exception {
getClient().perform(delete("/api/system/processes/" + process.getID()))
.andExpect(status().isUnauthorized());

String token = getAuthToken(admin.getEmail(), password);
getClient(token).perform(get("/api/system/processes/" + process.getID()))
.andExpect(status().isOk());
}

@Test
public void deleteProcessForDifferentUserForbiddenException() throws Exception {
String token = getAuthToken(eperson.getEmail(), password);

getClient(token).perform(delete("/api/system/processes/" + process.getID()))
.andExpect(status().isForbidden());

String adminToken = getAuthToken(admin.getEmail(), password);
getClient(adminToken).perform(get("/api/system/processes/" + process.getID()))
.andExpect(status().isOk());
}

@Test
public void getProcessNotExisting() throws Exception {
String token = getAuthToken(eperson.getEmail(), password);
Expand Down
Loading