Skip to content

Conversation

@Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Dec 13, 2025

Pull Request

This pull request adds new unit tests to increase the code coverage.

Pull Request (PR) description

This PR expands unit test coverage across all files for the FabricTools module across all categories. Increased code coverage percentage to 50%.

Task list

  • The PR represents a single logical change. i.e. Cosmetic updates should go in different PRs.
  • Added an entry under the Unreleased section of in the CHANGELOG.md as per format.
  • Local clean build passes without issue or fail tests (build.ps1 -ResolveDependency -Tasks build, test).
  • Comment-based help added/updated.
  • Examples appropriately added/updated.
  • Unit tests added/updated..
  • Integration tests added/updated (where possible).
  • Documentation added/updated (where applicable).
  • Code follows the contribution guidelines.

@NowinskiK NowinskiK linked an issue Dec 13, 2025 that may be closed by this pull request
@NowinskiK
Copy link
Contributor

Hello @Gijsreyn, big thanks for this HUGE PR! This looks very promising, please give me/us some time to ingest it.
I will do my best to review it asap, and come back to you with questions or just approve it :)

@Gijsreyn
Copy link
Contributor Author

@NowinskiK - I cannot understand why it's going to take so much time. Nah, of course, I'm kidding. I can totally understand! Take your time, and just hit me up if anything needs changing. There are 213 file changes with a TON of code :)

@NowinskiK
Copy link
Contributor

One small request: could you add one line to RELEASENOTES, please?
Otherwise, all looks good. A few tests don't work on my local machine, but I reckon it must be something on my side, as all runs on agents here look correct.

@Gijsreyn
Copy link
Contributor Author

@NowinskiK - perhaps I don't have my glasses on, but the only ReleaseNotes.md I can find, references to a dead file. I have updated the CHANGELOG.md.

@NowinskiK
Copy link
Contributor

Haha, sorry, yes Sir! That's the file I meant. Thank you.

@NowinskiK NowinskiK merged commit eb46f22 into dataplat:develop Dec 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Code Coverage

2 participants