fix: inconsistency in env var usage#61
Merged
estellebertrand merged 2 commits intochore/airlfow-3from Apr 2, 2026
Merged
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 29418647 | Triggered | Generic Password | 0640d10 | docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Pierlou
approved these changes
Apr 2, 2026
Contributor
Pierlou
left a comment
There was a problem hiding this comment.
I have not checked but if some variables are Airflow 3-only compatible, we should rather modify them in the dedicated PR
Author
|
The merge will solve that by directly adding my commits to the open PR you mention ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct some inconsistencies in the environment variables :
Changes in docker-compose :
AIRFLOW__CELERY__RESULT_BACKENDwith one containing variablesPOSTGRES_...variables use the actual env variablesChanges in .env.example :
AIRFLOW__CORE__SQL_ALCHEMY_CONNto Airflow 3 oneAIRFLOW__DATABASE__SQL_ALCHEMY_CONN_AIRFLOW_WWW_USER_USERNAMEand_AIRFLOW_WWW_USER_PASSWORDPOSTGRES_...variablesNote: GitGuardian raised an alarm for the default values used
airflowas login and secret (even though if it was already the default before for testing purpose) - alarm has been skipped since it's not a real secret but showcase value