Fix incremental table compilation failing on metadata.extraProperties - #2236
Open
fuzmish wants to merge 1 commit into
Open
Fix incremental table compilation failing on metadata.extraProperties#2236fuzmish wants to merge 1 commit into
fuzmish wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
This fails to compile:
Cause
verifyObjectMatchesProto(protoType, object) in common/protos/index.ts:
create()copies extraProperties as-is, without converting it to the Struct format.toObject()then can't read it as a Struct, soprotoCastObjectends up with an empty extraProperties.checkFieldsfindsmyFieldpresent in the raw object but missing from the round-tripped one, and throws.Fix
Convert metadata.extraProperties into the Struct wire format in IncrementalTable.verifyConfig(), before calling verifyObjectMatchesProto, so both sides of the comparison already have matching shapes.
The conversion logic already existed; it is extracted into a named, exported function and incremental_table.ts call it directly.
Test
bazel test $(bazel query 'kind(test, //core/...)')passed.Related: #2119