feat(filters): Add foundation + project and loc 1 filters - #203
Open
david-bretaud-dev wants to merge 6 commits into
Open
feat(filters): Add foundation + project and loc 1 filters #203david-bretaud-dev wants to merge 6 commits into
david-bretaud-dev wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights
Debatable
Big question now: for now (and then), I'll apply filters per layer. E.G have project filter for each layer separately/independently. It's unclear whether it should be a global filter (to apply to all layers) or not.
For project it would make sense, but for loc1 for instance (which is a FK), it wouldn't since it's a FK value to a specific resource that has meaning only for a specific layer.
I put only checkboxes for now (+ support for date range), I don't know if users would rather a select.
Known issue
When applying filters, the cluster count is not recomputed => you can visualize the filter being applied only when the picto are displayed.