refactor(filters): Preparation work before working on filters - #202
Open
david-bretaud-dev wants to merge 5 commits into
Open
refactor(filters): Preparation work before working on filters#202david-bretaud-dev wants to merge 5 commits into
david-bretaud-dev wants to merge 5 commits into
Conversation
david-bretaud-dev
force-pushed
the
david-bretaud-dev/prepare-filters
branch
from
August 20, 2026 20:16
ad52eea to
6f3d9ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of improvements and refactoring that will help for the filters implementation (spliting the work for easier reviewing)
Commit 1 - refactor(backend/map): Extract get user map in its service
Extract the map in a service file since I'll need it for filters (that will live in a services/filters.py file)
Commit 2 - refactor(external-data): Create boundary and context to use external data on demand
Make it easier to use external data in the future filters by creating an abstraction layer.
Commit 3 - fix(enquete): Add ? on project.trim since enquete does not have the field
Enquete popups are broken since they don't have a project field
Commit 4 - refactor(coordo): Fix coordo import to use facae
Add missing coordo facade usage
Commit 5 - refactor(layers): Move translations inside layers dict
Make it less cumbersom to find and use layers naming in translations => everything can be found under layers dict