Skip to content

Add Death Note provider#1829

Open
ferclager wants to merge 1 commit into
datafaker-net:mainfrom
ferclager:chore/add-death-note
Open

Add Death Note provider#1829
ferclager wants to merge 1 commit into
datafaker-net:mainfrom
ferclager:chore/add-death-note

Conversation

@ferclager
Copy link
Copy Markdown
Contributor

Add new entertainment provider for the Death Note manga/anime series. Includes characters, locations, quotes, and shinigami data.

Add new entertainment provider for the Death Note manga/anime series.
Includes characters, locations, quotes, and shinigami data.

Generated with [Devin](https://cli.devin.ai/docs)

Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@what-the-diff
Copy link
Copy Markdown

what-the-diff Bot commented Jun 1, 2026

PR Summary

  • Creation of a new DeathNote class
    This update introduces a new Java class named DeathNote. It's a part of the entertainment package and has new functionalities for delivering information related to the Death Note series - such as pulling data about characters, locations, quotes, and shinigami.

  • Update to EntertainmentProviders interface
    The EntertainmentProviders interface now includes a new method, deathNote(). This method will allow the retrieval of our newly developed DeathNote provider.

  • Alteration to EnFile class
    The getPath() method within the EnFile class has been changed to include death_note.yml. This is a new resource file.

  • Addition of death_note.yml file
    A new YAML file named death_note.yml has now been included. This file consists of lists of characters, locations, quotes, and shinigami from the Death Note series. It will be serving as the data source for our DeathNote class.

  • Introduction of the DeathNoteTest class
    There is now a new test class named DeathNoteTest. Its purpose is to verify the functionalities of our DeathNote provider and ensure that the methods pull the expected data from death_note.yml.

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.52%. Comparing base (1853d99) to head (2028f07).
⚠️ Report is 11 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1829      +/-   ##
============================================
+ Coverage     92.35%   92.52%   +0.16%     
- Complexity     3510     3522      +12     
============================================
  Files           343      344       +1     
  Lines          6962     6969       +7     
  Branches        684      684              
============================================
+ Hits           6430     6448      +18     
+ Misses          363      358       -5     
+ Partials        169      163       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev added this to the 2.6.0 milestone Jun 1, 2026
@asolntsev asolntsev added the enhancement New feature or request label Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants