Conversation
PR Summary
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1789 +/- ##
============================================
+ Coverage 92.28% 92.35% +0.06%
- Complexity 3445 3479 +34
============================================
Files 339 340 +1
Lines 6794 6881 +87
Branches 670 678 +8
============================================
+ Hits 6270 6355 +85
- Misses 356 361 +5
+ Partials 168 165 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
17a7a66 to
bfdf826
Compare
There was a problem hiding this comment.
Pull request overview
Adds a new Fingerprint base provider to generate synthetic fingerprint images as PNG bytes or base64 PNG data URLs, and wires it into the Faker provider surface and documentation.
Changes:
- Introduces
net.datafaker.providers.base.Fingerprintwithpng(...)andbase64(...)APIs (including pattern selection viaPatternType). - Registers the provider via
BaseProviders#fingerprint()and updates GraalVM native-image reachability metadata. - Adds provider documentation entries and a JUnit test suite for basic PNG/base64 validation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/net/datafaker/providers/base/Fingerprint.java | New provider implementation for generating fingerprint images and encoding as PNG / base64 data URLs |
| src/main/java/net/datafaker/providers/base/BaseProviders.java | Exposes the new provider via fingerprint() |
| src/main/resources/META-INF/native-image/reachability-metadata.json | Adds reachability entries for the new provider and its methods |
| src/test/java/net/datafaker/providers/base/FingerprintTest.java | Adds tests for PNG signature/dimensions and base64 data URL behavior |
| README.md | Adds “Fingerprint” to the provider list |
| docs/documentation/providers.md | Adds the Fingerprint provider to the provider table |
Usage: * `faker.fingerprint().png()` * `faker.fingerprint().png(300, 200, ARCH)` * `faker.fingerprint().base64()` * `faker.fingerprint().base64(800, 800, LOOP)`
bfdf826 to
2dc65dc
Compare
|
@asolntsev |
|
@mferrettmate are you using AI to write your messages? If so, could you please not do that? Thx |
Usage:
faker.fingerprint().png()faker.fingerprint().png(300, 200, ARCH)faker.fingerprint().base64()faker.fingerprint().base64(800, 800, LOOP)This is the first time when I tried to create PR with the help of AI (Claude).
I tuned the code format, added tests etc., but didn't dive deep into the algorithm. ¯¯_(ツ)_/¯¯
@mferretti Don't you want to try this version?