fix: likely typo in phone locale fallback: map Persian (fa) to IR instead of FR.#1788
Merged
asolntsev merged 1 commit intodatafaker-net:mainfrom Mar 29, 2026
Merged
Conversation
PR Summary
|
asolntsev
approved these changes
Mar 29, 2026
Collaborator
asolntsev
left a comment
asolntsev
left a comment
There was a problem hiding this comment.
Good point, "fa" stands for Persian language (Farsi) primarily used in Iran.
Thank you for the contribution.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
============================================
+ Coverage 92.31% 92.39% +0.07%
- Complexity 3446 3449 +3
============================================
Files 339 339
Lines 6794 6794
Branches 670 670
============================================
+ Hits 6272 6277 +5
+ Misses 355 353 -2
+ Partials 167 164 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
asolntsev
added a commit
that referenced
this pull request
Apr 5, 2026
When locale contains only language, but not country, the phone generator tries to guess the country. For few specific languages, the guess was wrong. It happened for languages where which occasionally matches some other country's code.
```
new Faker(new Language("am").phoneNumber(); // generated Armenian phone instead of Ethiopian
new Faker(new Language("ar").phoneNumber(); // generated Argentina phone instead of Saudi Arabia
etc.
```
case "fa" -> "FR"; // France
Inspired by #1788
asolntsev
added a commit
that referenced
this pull request
Apr 5, 2026
When locale contains only language, but not country, the phone generator tries to guess the country.
For few specific languages, the guess was wrong. It happened for languages which code occasionally matches some other country's code.
```
new Faker(new Language("am").phoneNumber(); // generated Armenian phone instead of Ethiopian
new Faker(new Language("ar").phoneNumber(); // generated Argentina phone instead of Saudi Arabia
```
etc.
Inspired by #1788
asolntsev
added a commit
that referenced
this pull request
Apr 5, 2026
When locale contains only language, but not country, the phone generator tries to guess the country.
For few specific languages, the guess was wrong. It happened for languages which code occasionally matches some other country's code.
```
new Faker(new Language("am").phoneNumber(); // generated Armenian phone instead of Ethiopian
new Faker(new Language("ar").phoneNumber(); // generated Argentina phone instead of Saudi Arabia
```
etc.
Inspired by #1788
kingthorin
pushed a commit
that referenced
this pull request
Apr 5, 2026
When locale contains only language, but not country, the phone generator tries to guess the country.
For few specific languages, the guess was wrong. It happened for languages which code occasionally matches some other country's code.
```
new Faker(new Language("am").phoneNumber(); // generated Armenian phone instead of Ethiopian
new Faker(new Language("ar").phoneNumber(); // generated Argentina phone instead of Saudi Arabia
```
etc.
Inspired by #1788
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a likely typo in the language-only phone locale fallback by mapping Persian (fa) to IR instead of FR. This prevents new Locale("fa") from generating French phone numbers, and adds a regression test to lock in the correct behavior.