Skip to content

Fix custom Windows install directory display - #64

Closed
wisdomqin wants to merge 2 commits into
mainfrom
codex/fix-windows-install-folder
Closed

Fix custom Windows install directory display#64
wisdomqin wants to merge 2 commits into
mainfrom
codex/fix-windows-install-folder

Conversation

@wisdomqin

@wisdomqin wisdomqin commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

What changed

  • locate the visible NSIS directory page instead of binding to electron-builder's hidden install-mode page
  • show the final application directory for every custom parent selection, for example D:\DSH Desktop in a formal build and D:\DSH Desktop Dev in a development preview
  • support drive roots, arbitrary subdirectories, Browse selections, and manually entered paths after the field loses focus
  • keep the directory-page watcher valid when navigating backward and forward in the installer
  • preserve electron-builder's existing install-time path safeguard

Root cause

The earlier fix only recognized drive roots and its page watcher stopped at the first child dialog. Electron-builder retains previous custom pages as hidden dialogs, so the handler could bind to the wrong page and never update the visible directory field.

Validation

  • npm test -- --run — 81 tests passed
  • npm run typecheck
  • git diff --check
  • cross-built the Windows x64 NSIS development installer successfully with electron-builder 26.15.3

The final visible-field behavior still needs confirmation with this PR's preview installer on Windows.

@wisdomqin wisdomqin changed the title Fix Windows drive-root install directory Fix custom Windows install directory display Aug 18, 2026
@wisdomqin

Copy link
Copy Markdown
Contributor Author

Windows validation preview: desktop-preview-20260818.1

Direct installer: dsh-desktop-dev-windows-x64-setup.exe

Built from commit 1a81095136c8e248720aa1cbdd148bdfe39c06f6. The Windows job passed tests, typecheck, both package builds, and the packaged Harness smoke test. Manual Windows confirmation is still required for the visible custom-directory behavior.

@wisdomqin

Copy link
Copy Markdown
Contributor Author

Closing this draft because the custom-directory display behavior still did not work reliably in Windows real-machine testing. This experiment was never merged into main; the existing drive-root compatibility already present on main is unaffected. We can revisit the installer UX later if it becomes important.

@wisdomqin wisdomqin closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant