Fix custom Windows install directory display - #64
Closed
wisdomqin wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
Windows validation preview: desktop-preview-20260818.1 Direct installer: dsh-desktop-dev-windows-x64-setup.exe Built from commit |
Contributor
Author
|
Closing this draft because the custom-directory display behavior still did not work reliably in Windows real-machine testing. This experiment was never merged into main; the existing drive-root compatibility already present on main is unaffected. We can revisit the installer UX later if it becomes important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
D:\DSH Desktopin a formal build andD:\DSH Desktop Devin a development previewRoot cause
The earlier fix only recognized drive roots and its page watcher stopped at the first child dialog. Electron-builder retains previous custom pages as hidden dialogs, so the handler could bind to the wrong page and never update the visible directory field.
Validation
npm test -- --run— 81 tests passednpm run typecheckgit diff --checkThe final visible-field behavior still needs confirmation with this PR's preview installer on Windows.