PRG-05: Channel routing bundle (from #338 #342 #344)#368
PRG-05: Channel routing bundle (from #338 #342 #344)#368nap-liu wants to merge 3 commits intodataelement:mainfrom
Conversation
…centralized token management Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…dcoded limits Remove redundant history[-ctx_size:] slicing in _call_agent_llm since all callers already truncate history via SQL .limit(ctx_size). The remaining channel handlers (websocket, dingtalk, discord, slack, wecom, teams, discord_gateway, wecom_stream) already use agent.context_window_size with DEFAULT_CONTEXT_WINDOW_SIZE=100 fallback. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Thanks for putting this bundle together. The problems it targets are valid, especially channel session reset and DingTalk identity matching, but I do not think this PR is safe to merge as-is because it mixes several behavioral changes and has a few concrete risks. Main concerns:
Recommendation: please split this bundle into smaller PRs: one for channel |
|
Closing this bundle per maintainer preference for focused single-concern PRs. The individual PRs remain open for review:
|
This regrouped PR combines the original changes from:\n- #338 dingtalk-user-matching\n- #342 channel-session-reset\n- #344 cross-channel-user-merge\n\nScope: channel identity/session routing behavior.