feat(testing): make the provision key path configurable via SNOWCAP_TEST_KEY_PATH - #53
Open
GClunies wants to merge 2 commits into
Open
feat(testing): make the provision key path configurable via SNOWCAP_TEST_KEY_PATH#53GClunies wants to merge 2 commits into
GClunies wants to merge 2 commits into
Conversation
…EST_KEY_PATH The default key location sits inside the checkout, so deleting the checkout (e.g. a git worktree) destroys the only credential for the test account's SERVICE admin. SNOWCAP_TEST_KEY_PATH lets contributors point provisioning at a durable directory once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
provisionwrote the test account admin's private key totests/.snowcap_test_account_rsa_key.p8by default. That path lives inside the checkout, so deleting the checkout (for example, removing a git worktree) destroys the only credential for the account's SERVICE admin user. The account is then unrecoverable by self-service. This happened to us today.Changes
--key-pathnow defaults to~/.snowcap/snowcap_test_account_rsa_key.p8, a durable per-user location outside any checkout$SNOWCAP_TEST_KEY_PATHoverrides the default for users who keep keys elsewheregenerate_rsa_keypaircreates the parent directory if neededTesting
pytest tests/test_manage_test_account.py: 72 passedruff checkandruff format --checkclean