Skip to content

Update deployment configs#6339

Draft
juliawu wants to merge 2 commits into
datacommonsorg:masterfrom
juliawu:mixer-deployment-testing
Draft

Update deployment configs#6339
juliawu wants to merge 2 commits into
datacommonsorg:masterfrom
juliawu:mixer-deployment-testing

Conversation

@juliawu
Copy link
Copy Markdown
Contributor

@juliawu juliawu commented Jun 4, 2026

Changes here must be paired with the changes in datacommonsorg/mixer#1920.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the deployment configurations by removing unnecessary resource specifications from the helm charts and updating the service group configuration in Skaffold profiles. These changes are intended to align with corresponding updates in the mixer repository to ensure consistent deployment behavior.

Highlights

  • Deployment Configuration Cleanup: Removed redundant resource, replica, and cache settings from the helm chart values for service groups.
  • Skaffold Profile Updates: Updated serviceGroups.recon configuration across all environments to null, replacing the previous explicit flag setting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the Helm chart configuration in values.yaml by removing redundant fields like replicas, resources, cacheSVG, and nodePool across multiple service groups. It also updates skaffold.yaml to set serviceGroups.recon to null instead of explicitly disabling its embeddings sidecar across various deployment profiles. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant