Skip to content

Eurostat Data Import - Death by week and sex & Divorce indicators#2039

Open
pravnkumar-cloudsufi wants to merge 12 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:eurostat_data_death_divorce
Open

Eurostat Data Import - Death by week and sex & Divorce indicators#2039
pravnkumar-cloudsufi wants to merge 12 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:eurostat_data_death_divorce

Conversation

@pravnkumar-cloudsufi
Copy link
Copy Markdown

@pravnkumar-cloudsufi pravnkumar-cloudsufi commented May 25, 2026

PR Checklist: https://drive.google.com/corp/drive/folders/19uraIXjS3R5bE7_NK8Xl_keFZCZspD5i?resourcekey=0-bEZP1Iy-DmoyBOK3Bmw6yQ

Import Name:
Death by week and sex - EuroStat_Deaths_by_week_and_sex
Divorce indicators - EuroStat_Divorce_Indicators

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two new Eurostat data imports for weekly deaths and divorce indicators, providing documentation, configuration, and automation scripts. The review identifies several critical issues, including incorrect file paths in the download scripts and missing output columns required for data consistency. Suggestions were also provided to use ISO 8601 week formats for dates to prevent collisions, standardize ratio mappings, and correct markdown formatting in the README files.

Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/deaths_by_week_and_sex_pvmap.csv Outdated
Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/run.sh Outdated
Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/run.sh Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/run.sh Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/run.sh Outdated
Comment thread statvar_imports/eurostat/deaths_by_week_and_sex/README.md Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/README.md Outdated
Comment thread statvar_imports/eurostat/divorce_indicators/divorce_indicators_pvmap.csv Outdated
@pravnkumar-cloudsufi pravnkumar-cloudsufi force-pushed the eurostat_data_death_divorce branch from 372f107 to 9200997 Compare June 3, 2026 10:16
@pravnkumar-cloudsufi
Copy link
Copy Markdown
Author

@gemini-code-assist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

The pull request adds two new Eurostat imports: 'Deaths by week and sex' and 'Divorce indicators'. The structure of the files, including the metadata, PV maps, and run scripts, is consistent with the existing import patterns in the repository. The configuration files and manifests appear to be correctly set up for the stat_var_processor.py tool.

@pravnkumar-cloudsufi pravnkumar-cloudsufi force-pushed the eurostat_data_death_divorce branch from 06b0d2a to 63197a5 Compare June 5, 2026 11:37
@pravnkumar-cloudsufi
Copy link
Copy Markdown
Author

@gemini-code-assist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Hello @pravnkumar-cloudsufi, thank you for reaching out. I have reviewed the pull request again, and the implementation for both 'Deaths by week and sex' and 'Divorce indicators' remains consistent with the existing import patterns in the repository. The configuration files, manifests, and run scripts are correctly set up for the stat_var_processor.py tool. No further issues were identified.

@pravnkumar-cloudsufi
Copy link
Copy Markdown
Author

@gemini-code-assist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Hello @pravnkumar-cloudsufi, thank you for the follow-up. I have reviewed the pull request once more and everything remains consistent with the repository's existing import patterns. The configuration files, manifests, and run scripts are correctly set up for the stat_var_processor.py tool. I have no further issues to identify, and the PR appears ready for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants