Conversation
Fixes #302 fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #302 fixed
Lab output (with modified logic):
[Check 84/90] Bootx Service tmp files... FAIL - OUTAGE WARNING!!
APIC ID APIC Name Folder Location Number of files
1 c-apic1 /firmware/tmp 1045996
2 c-apic2 /firmware/tmp 1137336
3 c-apic3 /firmware/tmp 1108184
Recommended Action: Review the workaround for the bug and apply it before upgrade
Reference Document: https://datacenter.github.io/ACI-Pre-Upgrade-Validation-Script/validations#bootx-service-tmp-files
Pytest results:
python3.12 -m pytest tests/checks/bootx_service_tmp_files_check
=================================================================================================== test session starts ===================================================================================================
platform darwin -- Python 3.12.12, pytest-7.4.0, pluggy-1.2.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
collected 6 items
tests/checks/bootx_service_tmp_files_check/test_bootx_service_tmp_files_check.py::test_logic[icurl_outputs0-fabric_nodes0-6.0(8h)-True-conn_cmds0-ERROR !!-expected_data0]
----------------------------------------------------------------------------------------------------- live log setup ------------------------------------------------------------------------------------------------------
[18:28:45.558 INFO init_system:6109(MainThread)] Cleaning up previous run files in preupgrade_validator_logs/
[18:28:45.558 INFO init_system:6111(MainThread)] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[18:28:45.559 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
[18:28:45.560 INFO _start_thread:1105(MainThread)] (bootx_service_tmp_files_check) Starting thread.
[18:28:45.560 INFO wrapper:1349(bootx_service_tmp_files_check)] Start bootx_service_tmp_files_check
[18:28:45.560 INFO update_result:1191(bootx_service_tmp_files_check)] Finalized result in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
PASSED [ 16%]
tests/checks/bootx_service_tmp_files_check/test_bootx_service_tmp_files_check.py::test_logic[icurl_outputs1-fabric_nodes1-6.0(8h)-False-conn_cmds1-ERROR !!-expected_data1]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[18:28:45.572 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
[18:28:45.573 INFO _start_thread:1105(MainThread)] (bootx_service_tmp_files_check) Starting thread.--------| 0/1 checks completed
[18:28:45.573 INFO wrapper:1349(bootx_service_tmp_files_check)] Start bootx_service_tmp_files_check
[18:28:45.573 INFO update_result:1191(bootx_service_tmp_files_check)] Finalized result in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
PASSED [ 33%]
tests/checks/bootx_service_tmp_files_check/test_bootx_service_tmp_files_check.py::test_logic[icurl_outputs2-fabric_nodes2-6.0(8h)-False-conn_cmds2-ERROR !!-expected_data2]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[18:28:45.586 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
[18:28:45.587 INFO _start_thread:1105(MainThread)] (bootx_service_tmp_files_check) Starting thread.--------| 0/1 checks completed
[18:28:45.587 INFO wrapper:1349(bootx_service_tmp_files_check)] Start bootx_service_tmp_files_check
[18:28:45.587 INFO update_result:1191(bootx_service_tmp_files_check)] Finalized result in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
PASSED [ 50%]
tests/checks/bootx_service_tmp_files_check/test_bootx_service_tmp_files_check.py::test_logic[icurl_outputs3-fabric_nodes3-6.0(8h)-False-conn_cmds3-PASS-expected_data3]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[18:28:45.601 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
[18:28:45.601 INFO _start_thread:1105(MainThread)] (bootx_service_tmp_files_check) Starting thread.
[18:28:45.601 INFO wrapper:1349(bootx_service_tmp_files_check)] Start bootx_service_tmp_files_check--------| 0/1 checks completed
[18:28:45.601 INFO update_result:1191(bootx_service_tmp_files_check)] Finalized result in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
PASSED [ 66%]
tests/checks/bootx_service_tmp_files_check/test_bootx_service_tmp_files_check.py::test_logic[icurl_outputs4-fabric_nodes4-6.0(8h)-False-conn_cmds4-FAIL - OUTAGE WARNING!!-expected_data4]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[18:28:45.615 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
[18:28:45.615 INFO _start_thread:1105(MainThread)] (bootx_service_tmp_files_check) Starting thread.
[18:28:45.615 INFO wrapper:1349(bootx_service_tmp_files_check)] Start bootx_service_tmp_files_check--------| 0/1 checks completed
[18:28:45.615 INFO update_result:1191(bootx_service_tmp_files_check)] Finalized result in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
PASSED [ 83%]
tests/checks/bootx_service_tmp_files_check/test_bootx_service_tmp_files_check.py::test_logic[icurl_outputs5-fabric_nodes5-6.0(8h)-False-conn_cmds5-ERROR !!-expected_data5]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[18:28:45.629 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
[18:28:45.629 INFO _start_thread:1105(MainThread)] (bootx_service_tmp_files_check) Starting thread.
[18:28:45.629 INFO wrapper:1349(bootx_service_tmp_files_check)] Start bootx_service_tmp_files_check--------| 0/1 checks completed
[18:28:45.630 INFO update_result:1191(bootx_service_tmp_files_check)] Finalized result in preupgrade_validator_logs/json_results/bootx_service_tmp_files_check.json
PASSED [100%]
==================================================================================================== 6 passed in 0.09s ====================================================================================================