Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #299 fixed
Lab Output (logic modified):
[Check 84/90] GX HW_Changes_Bit... FAIL - UPGRADE FAILURE!!
Switch ID Switch Name HW Changes Bits value
101 b-leaf1 0x3 Found!
103 b-leaf3 0x3 Found!
201 b-spine1 0x3 Found!
Pytest results:
((ACI-PRE) ) jeestrad@JEESTRAD-M-L6VV ACI-Pre-Upgrade-Validation-Script % python3.12 -m pytest tests/checks/gx_hw_changes_bit_check
=================================================================================================== test session starts ===================================================================================================
platform darwin -- Python 3.12.12, pytest-7.4.0, pluggy-1.2.0
rootdir: /Users/jeestrad/Documents/Python/pre-upgrade/ACI-Pre-Upgrade-Validation-Script
configfile: pytest.ini
collected 7 items
tests/checks/gx_hw_changes_bit_check/test_gx_hw_changes_bit_check.py::test_logic[icurl_outputs0-fabric_nodes0-4.2(3b)-4.2(4p)-False-conn_cmds0-N/A-expected_data0]
----------------------------------------------------------------------------------------------------- live log setup ------------------------------------------------------------------------------------------------------
[12:16:28.680 INFO init_system:6107(MainThread)] Cleaning up previous run files in preupgrade_validator_logs/
[12:16:28.681 INFO init_system:6109(MainThread)] Creating directories preupgrade_validator_logs/ and preupgrade_validator_logs/json_results/
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[12:16:28.682 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
[12:16:28.682 INFO _start_thread:1105(MainThread)] (gx_hw_changes_bit_check) Starting thread.
[12:16:28.682 INFO wrapper:1349(gx_hw_changes_bit_check)] Start gx_hw_changes_bit_check
[12:16:28.683 INFO update_result:1191(gx_hw_changes_bit_check)] Finalized result in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
PASSED [ 14%]
tests/checks/gx_hw_changes_bit_check/test_gx_hw_changes_bit_check.py::test_logic[icurl_outputs1-fabric_nodes1-4.2(5l)-6.0(1h)-False-conn_cmds1-N/A-expected_data1]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[12:16:28.696 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
[12:16:28.697 INFO _start_thread:1105(MainThread)] (gx_hw_changes_bit_check) Starting thread.
[12:16:28.697 INFO wrapper:1349(gx_hw_changes_bit_check)] Start gx_hw_changes_bit_check
[12:16:28.697 INFO update_result:1191(gx_hw_changes_bit_check)] Finalized result in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
PASSED [ 28%]
tests/checks/gx_hw_changes_bit_check/test_gx_hw_changes_bit_check.py::test_logic[icurl_outputs2-fabric_nodes2-4.2(1f)-5.2(7f)-False-conn_cmds2-N/A-expected_data2]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[12:16:28.711 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
[12:16:28.711 INFO _start_thread:1105(MainThread)] (gx_hw_changes_bit_check) Starting thread.
[12:16:28.711 INFO wrapper:1349(gx_hw_changes_bit_check)] Start gx_hw_changes_bit_check--------------------| 0/1 checks completed
[12:16:28.712 INFO update_result:1191(gx_hw_changes_bit_check)] Finalized result in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
PASSED [ 42%]
tests/checks/gx_hw_changes_bit_check/test_gx_hw_changes_bit_check.py::test_logic[icurl_outputs3-fabric_nodes3-4.2(3b)-4.2(4b)-True-conn_cmds3-ERROR !!-expected_data3]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[12:16:28.723 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
[12:16:28.723 INFO _start_thread:1105(MainThread)] (gx_hw_changes_bit_check) Starting thread.
[12:16:28.723 INFO wrapper:1349(gx_hw_changes_bit_check)] Start gx_hw_changes_bit_check
[12:16:28.723 INFO update_result:1191(gx_hw_changes_bit_check)] Finalized result in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
PASSED [ 57%]
tests/checks/gx_hw_changes_bit_check/test_gx_hw_changes_bit_check.py::test_logic[icurl_outputs4-fabric_nodes4-4.2(3b)-4.2(4p)-False-conn_cmds4-ERROR !!-expected_data4]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[12:16:28.737 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
[12:16:28.737 INFO _start_thread:1105(MainThread)] (gx_hw_changes_bit_check) Starting thread.
[12:16:28.738 INFO wrapper:1349(gx_hw_changes_bit_check)] Start gx_hw_changes_bit_check--------------------| 0/1 checks completed
[12:16:28.738 INFO update_result:1191(gx_hw_changes_bit_check)] Finalized result in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
PASSED [ 71%]
tests/checks/gx_hw_changes_bit_check/test_gx_hw_changes_bit_check.py::test_logic[icurl_outputs5-fabric_nodes5-4.2(3b)-4.2(4c)-False-conn_cmds5-PASS-expected_data5]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[12:16:28.751 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
[12:16:28.752 INFO _start_thread:1105(MainThread)] (gx_hw_changes_bit_check) Starting thread.--------------| 0/1 checks completed
[12:16:28.752 INFO wrapper:1349(gx_hw_changes_bit_check)] Start gx_hw_changes_bit_check
[12:16:28.752 INFO update_result:1191(gx_hw_changes_bit_check)] Finalized result in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
PASSED [ 85%]
tests/checks/gx_hw_changes_bit_check/test_gx_hw_changes_bit_check.py::test_logic[icurl_outputs6-fabric_nodes6-4.2(3b)-4.2(4p)-False-conn_cmds6-FAIL - UPGRADE FAILURE!!-expected_data6]
------------------------------------------------------------------------------------------------------ live log call ------------------------------------------------------------------------------------------------------
[12:16:28.766 INFO init_result:1182(MainThread)] Initialized in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
[12:16:28.766 INFO _start_thread:1105(MainThread)] (gx_hw_changes_bit_check) Starting thread.--------------| 0/1 checks completed
[12:16:28.766 INFO wrapper:1349(gx_hw_changes_bit_check)] Start gx_hw_changes_bit_check
[12:16:28.767 INFO update_result:1191(gx_hw_changes_bit_check)] Finalized result in preupgrade_validator_logs/json_results/gx_hw_changes_bit_check.json
PASSED [100%]
==================================================================================================== 7 passed in 0.10s ====================================================================================================